Coalesce scale reads for non-multiple of block N#1030
Open
Conversation
Signed-off-by: xintin <gaurav.verma@amd.com>
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
xintin/coalesce_b_scale_nonmultiple_blkN
branch
from
99133ff to
f6531d4
Compare
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
xintin/coalesce_b_scale_nonmultiple_blkN
branch
from
f6531d4 to
1a5f07e
Compare
Signed-off-by: xintin <gaurav.verma@amd.com>
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
changed the title
xintin
changed the title
Hardcode84
reviewed
Mar 4, 2026
Signed-off-by: xintin <gaurav.verma@amd.com>
Hardcode84
reviewed
Mar 4, 2026
| lo_custom.vector_shapes | ||
| ) | ||
| lo_mask = _flatten_bounds_to_mask_expr(lo_custom, symbolic_shape) | ||
| if lo_mask is not None: |
Contributor
There was a problem hiding this comment.
Why can't we attach new mask to the new read op?
Contributor
Author
There was a problem hiding this comment.
two original reads (lo and hi) can have different bounds checks. Each one has its own index and bounds. After coalescing, there is only one merged read op that loads a wider vector covering both lo and hi elements. We can't attach two different masks to that single read because each slice corresponds to one of the original reads and need that original read's bounds condition applied independently.
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
xintin/coalesce_b_scale_nonmultiple_blkN
branch
from
cba078c to
f83061e
Compare
Signed-off-by: xintin <gaurav.verma@amd.com>
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
xintin/coalesce_b_scale_nonmultiple_blkN
branch
2 times, most recently
from
014a531 to
48d39d6
Compare
Signed-off-by: xintin <gaurav.verma@amd.com>
xintin
force-pushed
the
xintin/coalesce_b_scale_nonmultiple_blkN
branch
from
48d39d6 to
8c89da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.